New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Laravel5 module seeCurrentRouteIs crash #2593

Merged
merged 1 commit into from Nov 30, 2015

Conversation

Projects
None yet
2 participants
@maddhatter
Contributor

maddhatter commented Nov 30, 2015

seeCurrentRouteIs() will throw an exception if the routes don't match:

[ErrorException] Object of class Illuminate\Routing\Route could not be converted to string

It should use the $currentRouteName instead of the route object when creating the error message.

@maddhatter maddhatter changed the title from Use route name instead of the route to Fix Laravel5 module seeCurrentRouteIs crash Nov 30, 2015

janhenkgerritsen added a commit that referenced this pull request Nov 30, 2015

Merge pull request #2593 from maddhatter/route-name-fix
Fix Laravel5 module seeCurrentRouteIs crash

@janhenkgerritsen janhenkgerritsen merged commit 5537dbc into Codeception:2.1 Nov 30, 2015

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@janhenkgerritsen

This comment has been minimized.

Show comment
Hide comment
@janhenkgerritsen

janhenkgerritsen Nov 30, 2015

Contributor

Thanks!

Contributor

janhenkgerritsen commented Nov 30, 2015

Thanks!

@maddhatter maddhatter deleted the maddhatter:route-name-fix branch Nov 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment