Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Laravel modules #2602

Merged
merged 3 commits into from Dec 2, 2015
Merged

Refactor Laravel modules #2602

merged 3 commits into from Dec 2, 2015

Conversation

@janhenkgerritsen
Copy link
Contributor

@janhenkgerritsen janhenkgerritsen commented Dec 2, 2015

I refactored the Laravel modules due to the results of the discussion in #2596. Besides implementing the fix mentioned in that issue I also implemented several other improvements to the internals of the modules.

I also removed the enableMiddleware and enableEvents methods from the Laravel 5 module, because I think it is not necessary to be able to enable the middleware/events again in the same test after disabling them. And the implementation of enableEvents will not be simple due to the refactoring in this PR.

janhenkgerritsen added a commit that referenced this pull request Dec 2, 2015
@janhenkgerritsen janhenkgerritsen merged commit 28dd2b5 into Codeception:2.1 Dec 2, 2015
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant