Refactor Laravel modules #2602

Merged
merged 3 commits into from Dec 2, 2015

Conversation

Projects
None yet
1 participant
@janhenkgerritsen
Contributor

janhenkgerritsen commented Dec 2, 2015

I refactored the Laravel modules due to the results of the discussion in #2596. Besides implementing the fix mentioned in that issue I also implemented several other improvements to the internals of the modules.

I also removed the enableMiddleware and enableEvents methods from the Laravel 5 module, because I think it is not necessary to be able to enable the middleware/events again in the same test after disabling them. And the implementation of enableEvents will not be simple due to the refactoring in this PR.

janhenkgerritsen added a commit that referenced this pull request Dec 2, 2015

Merge pull request #2602 from janhenkgerritsen/2.1
Refactor Laravel modules

@janhenkgerritsen janhenkgerritsen merged commit 28dd2b5 into Codeception:2.1 Dec 2, 2015

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment