New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements PartedModule in Symfony2 module with services part #2629

Merged
merged 2 commits into from Dec 15, 2015

Conversation

Projects
None yet
4 participants
@laszlo-karpati
Contributor

laszlo-karpati commented Dec 11, 2015

Codeception/Codeception#2435

Codeception/Codeception#2470

Usage example:

class_name: AcceptanceTester
modules:
    enabled:
        - Symfony2:
            part: SERVICES
            app_path: '../../../app'
            var_path: '../../../app'
        - Doctrine2:
            depends: Symfony2
            cleanup: false
        - Asserts:
        - WebDriver:
            url: http://your-url.com
            host: '127.0.0.1'
            browser: phantomjs
            window_size: 1280x800
            request_timeout: 30
            debug_log_entries: 100
            wait: 1
            capabilities:
                webStorageEnabled: true
                handlesAlerts: true
        - \FrontendAdminBundle\Helper\Acceptance
@raistlin

View changes

Show outdated Hide outdated src/Codeception/Module/Symfony2.php
*/
public function _parts()
{
return ['serives'];

This comment has been minimized.

@raistlin

raistlin Dec 12, 2015

Member

Shouldn't this be 'services' ?

@raistlin

raistlin Dec 12, 2015

Member

Shouldn't this be 'services' ?

Laszlo Karpati
@laszlo-karpati

This comment has been minimized.

Show comment
Hide comment
@laszlo-karpati

laszlo-karpati Dec 12, 2015

Contributor

@raistlin :
Sure, thanks! Fixed.

Contributor

laszlo-karpati commented Dec 12, 2015

@raistlin :
Sure, thanks! Fixed.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Dec 15, 2015

Member

Good one. Thank you

Member

DavertMik commented Dec 15, 2015

Good one. Thank you

DavertMik added a commit that referenced this pull request Dec 15, 2015

Merge pull request #2629 from laszlo-karpati/dev-parted-symfony2-module
implements PartedModule in Symfony2 module with services part

@DavertMik DavertMik merged commit e5af08d into Codeception:2.1 Dec 15, 2015

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Dec 15, 2015

Member

@janhenkgerritsen should this be ported to Laravel as well?

Also this should be documented somehow.

Member

DavertMik commented Dec 15, 2015

@janhenkgerritsen should this be ported to Laravel as well?

Also this should be documented somehow.

@janhenkgerritsen

This comment has been minimized.

Show comment
Hide comment
@janhenkgerritsen

janhenkgerritsen Dec 16, 2015

Contributor

@DavertMik the Laravel modules already implement the PartedModule interface.

Contributor

janhenkgerritsen commented Dec 16, 2015

@DavertMik the Laravel modules already implement the PartedModule interface.

@laszlo-karpati laszlo-karpati deleted the laszlo-karpati:dev-parted-symfony2-module branch Dec 24, 2015

@laszlo-karpati laszlo-karpati restored the laszlo-karpati:dev-parted-symfony2-module branch Dec 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment