New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seeCurrentRouteMatches function to the symfony2 module #2665

Merged
merged 3 commits into from Feb 4, 2016

Conversation

Projects
None yet
4 participants
@laszlo-karpati
Contributor

laszlo-karpati commented Dec 24, 2015

#2664

Unlike seeCurrentRouteIs, this can matches without exact route parameters.

Usage example:

$I->amOnRoute('posts.create');    # admin/posts/create
$I->fillField(['name' => 'title'],  "Hello World!");
$I->click('Save');
$I->seeCurrentRouteMatches('posts.edit');    # admin/posts/123/edit
@Nitpick-CI

View changes

Show outdated Hide outdated src/Codeception/Module/Symfony2.php
@Nitpick-CI

View changes

Show outdated Hide outdated src/Codeception/Module/Symfony2.php
@Nitpick-CI

View changes

Show outdated Hide outdated src/Codeception/Module/Symfony2.php
@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Dec 24, 2015

Member

@laszlo-karpati thanks. Could you fix the formatting?
@raistlin could you review it?

Member

DavertMik commented Dec 24, 2015

@laszlo-karpati thanks. Could you fix the formatting?
@raistlin could you review it?

@DavertMik

View changes

Show outdated Hide outdated src/Codeception/Module/Symfony2.php
@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Dec 24, 2015

Member

I think the name can be changed. matches is more about regex matching. To check the inclusion of a string we should stick to our defaults. So I'd propose:

seeInCurrentRoute()
seeCurrentRouteContians()

or smth like that.

Member

DavertMik commented Dec 24, 2015

I think the name can be changed. matches is more about regex matching. To check the inclusion of a string we should stick to our defaults. So I'd propose:

seeInCurrentRoute()
seeCurrentRouteContians()

or smth like that.

@laszlo-karpati

This comment has been minimized.

Show comment
Hide comment
@laszlo-karpati

laszlo-karpati Dec 25, 2015

Contributor

@DavertMik thanks. I have fixed the code style and the missing quotes in the parameters. I renamed the funciton name too.

Contributor

laszlo-karpati commented Dec 25, 2015

@DavertMik thanks. I have fixed the code style and the missing quotes in the parameters. I renamed the funciton name too.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Dec 25, 2015

Member

Thanks. @raistlin could you do an additional review for this PR and merge it?

Member

DavertMik commented Dec 25, 2015

Thanks. @raistlin could you do an additional review for this PR and merge it?

@DavertMik DavertMik added the Symfony label Dec 29, 2015

@laszlo-karpati

This comment has been minimized.

Show comment
Hide comment
@laszlo-karpati

laszlo-karpati Jan 27, 2016

Contributor

Is there any updates on this?

Contributor

laszlo-karpati commented Jan 27, 2016

Is there any updates on this?

@raistlin

This comment has been minimized.

Show comment
Hide comment
@raistlin

raistlin Feb 4, 2016

Member

Sorry for late response.

Member

raistlin commented Feb 4, 2016

Sorry for late response.

raistlin added a commit that referenced this pull request Feb 4, 2016

Merge pull request #2665 from laszlo-karpati/symfony2-seeCurrentRoute…
…Matches

Add seeCurrentRouteMatches function to the symfony2 module

@raistlin raistlin merged commit d86fc97 into Codeception:2.1 Feb 4, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment