New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding problems in PHP prior to 5.6 related to #120 and #2810 #2831

Merged
merged 1 commit into from Feb 22, 2016

Conversation

Projects
None yet
3 participants
@pejaycz
Contributor

pejaycz commented Feb 22, 2016

Fix utf-8 encoding issue in PHP < 5.6 (mb_* functions default charset)

Before

problem

After

fix

raistlin added a commit that referenced this pull request Feb 22, 2016

Merge pull request #2831 from pejaycz/fix-encoding-problems-for-older…
…-php-versions

Fix encoding problems in PHP prior to 5.6 related to #120 and #2810

@raistlin raistlin merged commit 7a1066b into Codeception:2.1 Feb 22, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

@pejaycz pejaycz deleted the pejaycz:fix-encoding-problems-for-older-php-versions branch Feb 23, 2016

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Feb 23, 2016

Member

This will need to be redone for master branch, because I added more mb_strlen and mb_substr calls in https://github.com/Codeception/Codeception/pull/2784/files (but now I see a few places that needs replacing with mb_ equivalents in it).

A few failing tests that could reproduce these multibyte issues would be nice too.

Member

Naktibalda commented Feb 23, 2016

This will need to be redone for master branch, because I added more mb_strlen and mb_substr calls in https://github.com/Codeception/Codeception/pull/2784/files (but now I see a few places that needs replacing with mb_ equivalents in it).

A few failing tests that could reproduce these multibyte issues would be nice too.

pejaycz added a commit to pejaycz/Codeception that referenced this pull request Feb 23, 2016

samdark added a commit that referenced this pull request Feb 23, 2016

Merge pull request #2835 from pejaycz/redone-fix-encoding-problems-fo…
…r-older-php-versions

Fix encoding problems in PHP prior to 5.6 related to #2831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment