New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set upper boundary of supported PHPUnit versions to <5.4 #3080

Closed
wants to merge 1 commit into
base: 2.1
from

Conversation

Projects
None yet
2 participants
@Naktibalda
Member

Naktibalda commented May 4, 2016

PHPUnit 5.4 is likely to break Codeception\Util\Stub, so I'm setting this restriction to prevent automatic upgrade to PHPUnit 5.4

I will revisit this issue in June when PHPUnit 5.4 is released.

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda
Member

Naktibalda commented May 4, 2016

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik May 9, 2016

Member

This should not affect users that are not using Codeception\Util\Stub. So I'm against setting upper boundary. What we can do is to throw an exception with a hint to downgrade to PHPUnit v5.3 in class. And update the changelog

Member

DavertMik commented May 9, 2016

This should not affect users that are not using Codeception\Util\Stub. So I'm against setting upper boundary. What we can do is to throw an exception with a hint to downgrade to PHPUnit v5.3 in class. And update the changelog

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda May 11, 2016

Member

It won't do much harm if the users will not be able to upgrade to Phpunit 5.4 for a week. But if someone really want it, they could use the penultimate version of Codeception which has no restriction.

There is a risk and I think that it would be safer to put a restriction. But if you disagree, then we can do nothing and see how it works out.

Member

Naktibalda commented May 11, 2016

It won't do much harm if the users will not be able to upgrade to Phpunit 5.4 for a week. But if someone really want it, they could use the penultimate version of Codeception which has no restriction.

There is a risk and I think that it would be safer to put a restriction. But if you disagree, then we can do nothing and see how it works out.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik May 11, 2016

Member

Oh, what a mess there in Codeception\Util\Stub :(

Member

DavertMik commented May 11, 2016

Oh, what a mess there in Codeception\Util\Stub :(

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik
Member

DavertMik commented May 11, 2016

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Jun 3, 2016

Member

So we actually needed it.

Member

Naktibalda commented Jun 3, 2016

So we actually needed it.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Jun 3, 2016

Member

Yes :(
Actually the only change which really affected us was not in PHPUnit itself but in PHPUnit Code overage :( I suppose it was impossible to predict this

Member

DavertMik commented Jun 3, 2016

Yes :(
Actually the only change which really affected us was not in PHPUnit itself but in PHPUnit Code overage :( I suppose it was impossible to predict this

@Naktibalda Naktibalda deleted the Naktibalda:phpunit-5.4 branch Aug 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment