Fix container issue in Lumen Module #3124

Merged
merged 1 commit into from May 26, 2016

Conversation

Projects
None yet
3 participants
@kt81
Contributor

kt81 commented May 24, 2016

In Lumen module, initializeLumen() method has been called twice on that starts. (_initialize, _before)
That causes a problem that the IoC container does not store any singleton instances which created via Facade.
Facade::clearResolvedInstance() should be called every before bootApplication().

I guess #2607 is same problem.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik May 25, 2016

Member

@janhenkgerritsen could you look into it?

Member

DavertMik commented May 25, 2016

@janhenkgerritsen could you look into it?

@janhenkgerritsen

This comment has been minimized.

Show comment
Hide comment
@janhenkgerritsen

janhenkgerritsen May 26, 2016

Contributor

I will look into it, I still need to bring the structure of the Lumen module a bit more in line with the structure of the Laravel modules. Also, there were some significant breaking changes with the release of Lumen 5.2, so the module probably needs some work for that as well.

I am very busy right now, and I am also going away on holiday soon, so it will probably take a while before I can work on the Lumen module. For now I will merge this PR since it looks good and does not break any tests. I can rework it later if necessary.

Contributor

janhenkgerritsen commented May 26, 2016

I will look into it, I still need to bring the structure of the Lumen module a bit more in line with the structure of the Laravel modules. Also, there were some significant breaking changes with the release of Lumen 5.2, so the module probably needs some work for that as well.

I am very busy right now, and I am also going away on holiday soon, so it will probably take a while before I can work on the Lumen module. For now I will merge this PR since it looks good and does not break any tests. I can rework it later if necessary.

@janhenkgerritsen janhenkgerritsen merged commit dc50f78 into Codeception:2.1 May 26, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

@kt81 kt81 deleted the kt81:fix-lumen branch May 27, 2016

@kt81

This comment has been minimized.

Show comment
Hide comment
@kt81

kt81 May 27, 2016

Contributor

Thank you!! 😂

Contributor

kt81 commented May 27, 2016

Thank you!! 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment