New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format with Double-Width Characters #3130

Merged
merged 2 commits into from May 30, 2016

Conversation

Projects
None yet
4 participants
@kt81
Contributor

kt81 commented May 26, 2016

When the test case named with double-width characters, test result's format is broken.

2016-05-26 19 13 23

after this fix:

2016-05-26 19 13 59

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda May 26, 2016

Member

Are you sure that you don't need to update getLength method too?

Member

Naktibalda commented May 26, 2016

Are you sure that you don't need to update getLength method too?

@raistlin

This comment has been minimized.

Show comment
Hide comment
@raistlin

raistlin May 26, 2016

Member

A better solution would be update getLength method and use $this->getLength() on width method.

So message length is only calculated on the same place.

Member

raistlin commented May 26, 2016

A better solution would be update getLength method and use $this->getLength() on width method.

So message length is only calculated on the same place.

@kt81

This comment has been minimized.

Show comment
Hide comment
@kt81

kt81 May 27, 2016

Contributor

Thank you for your comments. 😭

I changed that to use getLength() method.
getLength() is used only by Console::writeFinishedTest for now.
In most cases we may not want that the "Length" contains tags. So getLength will do strip_tags in default.
(apply('strip_tags') has Side Effect.)

Contributor

kt81 commented May 27, 2016

Thank you for your comments. 😭

I changed that to use getLength() method.
getLength() is used only by Console::writeFinishedTest for now.
In most cases we may not want that the "Length" contains tags. So getLength will do strip_tags in default.
(apply('strip_tags') has Side Effect.)

@DavertMik DavertMik merged commit 166b5b4 into Codeception:2.1 May 30, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

@kt81 kt81 deleted the kt81:fix-alignment branch May 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment