#3128 Fixed stack overflow too comples regex #3138

Merged
merged 1 commit into from May 30, 2016

Conversation

Projects
None yet
3 participants
@dima-stefantsov
Contributor

dima-stefantsov commented May 30, 2016

Simple lazy/non-greedy match-all instead of complex non-capturing negative lookahead.

Still matches both single line and multiline comments. Just like it did before.
Matching single-line comments should not be required, but excluding them would make regex more complex.

#3128 Fixed stack overflow too comples regex
Simple lazy/non-greedy match-all instead of complex non-capturing negative lookahead.

Still matches both single line and multiline comments. Just like it did before.
Matching single-line comments should not be required, but excluding them would make regex more complex.
@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda May 30, 2016

Member

Thank you, it looks good to me.

Member

Naktibalda commented May 30, 2016

Thank you, it looks good to me.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik May 30, 2016

Member

The only problem I don't know how to mention it in changelog. In other things, looks good to me too

Member

DavertMik commented May 30, 2016

The only problem I don't know how to mention it in changelog. In other things, looks good to me too

@DavertMik DavertMik merged commit 31f83f5 into Codeception:2.1 May 30, 2016

2 of 3 checks passed

semaphoreci The build failed on Semaphore.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment