New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3191 change ucfirst for multibyte character encodings #3192

Merged
merged 1 commit into from Jun 12, 2016

Conversation

Projects
None yet
2 participants
@itigoppo
Contributor

itigoppo commented Jun 8, 2016

No description provided.

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Jun 10, 2016

Member
  1. Please make request to 2.1 branch instead.
  2. There is a block of code exactly like this one in https://github.com/Codeception/Codeception/blob/2.1.10/src/Codeception/Subscriber/Console.php#L527 it would be good to make it a function somewhere.
Member

Naktibalda commented Jun 10, 2016

  1. Please make request to 2.1 branch instead.
  2. There is a block of code exactly like this one in https://github.com/Codeception/Codeception/blob/2.1.10/src/Codeception/Subscriber/Console.php#L527 it would be good to make it a function somewhere.
@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Jun 12, 2016

Member

Actually, this PR is good enough.
It can't go to 2.1, because Codeception/Test/Cept.php does not exist in 2.1

Member

Naktibalda commented Jun 12, 2016

Actually, this PR is good enough.
It can't go to 2.1, because Codeception/Test/Cept.php does not exist in 2.1

@Naktibalda Naktibalda merged commit 70539cb into Codeception:2.2 Jun 12, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment