New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gherkin languages support #3203

Merged
merged 2 commits into from Jun 12, 2016

Conversation

Projects
None yet
2 participants
@dizzy7
Contributor

dizzy7 commented Jun 10, 2016

No description provided.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Jun 11, 2016

Member

I've been waiting for such PR but current implementation can't be accepted.
Would you mind to improve it so it could actually work for all distributions?

Member

DavertMik commented Jun 11, 2016

I've been waiting for such PR but current implementation can't be accepted.
Would you mind to improve it so it could actually work for all distributions?

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Jun 11, 2016

Member

Btw, how would I set the language to use? I think there should be something like in config:

gherkin:
    language: en

but how to pass it to Gherkin parser?

Member

DavertMik commented Jun 11, 2016

Btw, how would I set the language to use? I think there should be something like in config:

gherkin:
    language: en

but how to pass it to Gherkin parser?

@dizzy7

This comment has been minimized.

Show comment
Hide comment
@dizzy7

dizzy7 Jun 11, 2016

Contributor

I agree. Unfortunately I haven't found a better way to do it than using reflection.

About choosing a language - there is a standart way in gherkin to point a language in the first line of each particular file; for example, it's "#language: ru" for russian. This allows to write tests in several languages, and I can't see why to include it into the configuration.

Contributor

dizzy7 commented Jun 11, 2016

I agree. Unfortunately I haven't found a better way to do it than using reflection.

About choosing a language - there is a standart way in gherkin to point a language in the first line of each particular file; for example, it's "#language: ru" for russian. This allows to write tests in several languages, and I can't see why to include it into the configuration.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Jun 12, 2016

Member

About choosing a language - there is a standart way in gherkin to point a language in the first line of each particular file; for example, it's "#language: ru" for russian. This allows to write tests in several languages, and I can't see why to include it into the configuration.

Oh, thanks, I didn't know that. Looks good then 👍

Member

DavertMik commented Jun 12, 2016

About choosing a language - there is a standart way in gherkin to point a language in the first line of each particular file; for example, it's "#language: ru" for russian. This allows to write tests in several languages, and I can't see why to include it into the configuration.

Oh, thanks, I didn't know that. Looks good then 👍

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Jun 12, 2016

Member

Thanks. Looks good now

Member

DavertMik commented Jun 12, 2016

Thanks. Looks good now

@DavertMik DavertMik merged commit bf4f171 into Codeception:2.2 Jun 12, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

@dizzy7 dizzy7 deleted the dizzy7:gherkin-lang branch Jun 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment