New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Symfony tests always fail when the profiler is disabled #3223

Merged
merged 1 commit into from Jun 17, 2016

Conversation

Projects
None yet
3 participants
@dizzy7
Contributor

dizzy7 commented Jun 15, 2016

No description provided.

@DavertMik DavertMik added the Symfony label Jun 15, 2016

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Jun 15, 2016

Member

@raistlin is everything ok here?

Member

DavertMik commented Jun 15, 2016

@raistlin is everything ok here?

@dizzy7

This comment has been minimized.

Show comment
Hide comment
@dizzy7

dizzy7 Jun 16, 2016

Contributor

Code using this method (debugResponse, seeEmailIsSent) takes into account the possibility of lack of service profiler.
In my case (258 gherkin tests) everything works properly. Besides, disabling profile service in symfony config reduce memory consumption and speedup tests (7.02 minutes, 198MB -> 5.79 minutes, 158.00MB)

Contributor

dizzy7 commented Jun 16, 2016

Code using this method (debugResponse, seeEmailIsSent) takes into account the possibility of lack of service profiler.
In my case (258 gherkin tests) everything works properly. Besides, disabling profile service in symfony config reduce memory consumption and speedup tests (7.02 minutes, 198MB -> 5.79 minutes, 158.00MB)

@raistlin

This comment has been minimized.

Show comment
Hide comment
@raistlin

raistlin Jun 16, 2016

Member

Seems ok.

Member

raistlin commented Jun 16, 2016

Seems ok.

@DavertMik DavertMik merged commit 3bb99ef into Codeception:2.1 Jun 17, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Jun 17, 2016

Member

Thanks

Member

DavertMik commented Jun 17, 2016

Thanks

@DavertMik DavertMik added this to the 2.2.2 milestone Jun 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment