New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle deprecation messages according to error_level setting #3460

Merged
merged 4 commits into from Aug 26, 2016

Conversation

Projects
None yet
2 participants
@Naktibalda
Member

Naktibalda commented Aug 22, 2016

Fixes #3424

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Aug 22, 2016

Member

It appears that we don't want to respect error_level for all levels, it has to be limited to E_USER_DEPRECATED.

Member

Naktibalda commented Aug 22, 2016

It appears that we don't want to respect error_level for all levels, it has to be limited to E_USER_DEPRECATED.

@Naktibalda Naktibalda changed the title from All error messages are handled according to error_level setting to Handle deprecation messages according to error_level setting Aug 24, 2016

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Aug 24, 2016

Member

The test is flaky, I didn't expect that.

Member

Naktibalda commented Aug 24, 2016

The test is flaky, I didn't expect that.

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Aug 25, 2016

Member

Oh, I haven't noticed that Notification::all() clears the old messages.

Member

Naktibalda commented Aug 25, 2016

Oh, I haven't noticed that Notification::all() clears the old messages.

use Codeception\Subscriber\ErrorHandler;
use Codeception\Suite;
class ErrorHandlerTest extends \PHPUnit_Framework_TestCase

This comment has been minimized.

@DavertMik

DavertMik Aug 26, 2016

Member

wow, that's cool

@DavertMik

DavertMik Aug 26, 2016

Member

wow, that's cool

@DavertMik DavertMik merged commit 0a7395e into Codeception:2.2 Aug 26, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

@Naktibalda Naktibalda deleted the Naktibalda:2.2-error-level branch Dec 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment