New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Doctrine\ORM\EntityManagerInterface to check for valid em instance #3467

Merged
merged 1 commit into from Aug 24, 2016

Conversation

Projects
None yet
3 participants
@akbwm
Contributor

akbwm commented Aug 24, 2016

Use \Doctrine\ORM\EntityManagerInterface instead of
\Doctrine\ORM\EntityManager to check for valid entity manager in
Doctrine2 module.

#3459
Use \Doctrine\ORM\EntityManagerInterface instead of
\Doctrine\ORM\EntityManager to check for valid entity manager in
Doctrine2 module.

@DavertMik DavertMik added the Doctrine label Aug 24, 2016

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Aug 24, 2016

Member

@raistlin looks good to me. Please merge if it is ok

Member

DavertMik commented Aug 24, 2016

@raistlin looks good to me. Please merge if it is ok

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Aug 24, 2016

Member

ZF2 Doctrine tests passed, so it must be good

Member

Naktibalda commented Aug 24, 2016

ZF2 Doctrine tests passed, so it must be good

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Aug 24, 2016

Member

Thanks

Member

DavertMik commented Aug 24, 2016

Thanks

@DavertMik DavertMik merged commit 76ec0ad into Codeception:2.2 Aug 24, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

@akbwm akbwm deleted the akbwm:3459-useEntityManagerInterface branch Aug 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment