Remove methods from Laravel5 module _after hook #3493

Merged
merged 4 commits into from Sep 7, 2016

Conversation

Projects
None yet
2 participants
@janhenkgerritsen
Contributor

janhenkgerritsen commented Sep 7, 2016

This should fix #3483.

My first attempt to fix this issue was to test if a method logout existed on the guard object, but this does not work because the method will sometimes be called via magic methods.

After that I decided to just remove the call altogether, because I could not think of a good reason why the calls were there in the first place. Probably some leftover code from an earlier version of the module. I also deleted two other method calls for the same reasons.

@DavertMik DavertMik merged commit cf7f152 into Codeception:2.2 Sep 7, 2016

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

chris1312 added a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017

Remove methods from Laravel5 module _after hook (#3493)
* Add docblock

* Remove methods from Laravel5 module _after hook

* Update Travis to not run Laravel 5 sample on PHP 5.5

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment