New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape tags in debug output #3507

Merged
merged 5 commits into from Sep 13, 2016

Conversation

Projects
None yet
3 participants
@Naktibalda
Member

Naktibalda commented Sep 10, 2016

I found Symfony\Component\Console\Formatter\OutputFormatter::escape and added it to all relevant places that I could find:

  • codecept_debug
  • diff output
  • assertion messages and stack traces
  • step parameters

Fixes #3495

Show outdated Hide outdated src/Codeception/Lib/Console/Colorizer.php
@@ -1,6 +1,7 @@
<?php
namespace Codeception\Lib\Console;
use Symfony\Component\Console\Formatter\OutputFormatter;

This comment has been minimized.

@Nitpick-CI

Nitpick-CI Sep 10, 2016

There must be one blank line after the last USE statement; 0 found;

@Nitpick-CI

Nitpick-CI Sep 10, 2016

There must be one blank line after the last USE statement; 0 found;

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Sep 10, 2016

Member

Looks good! 👍

Member

DavertMik commented Sep 10, 2016

Looks good! 👍

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Sep 11, 2016

Member

Today I tested and escaped tags in the output of failed step in MetaStep (by using Step Object).
I think that's everything.

Member

Naktibalda commented Sep 11, 2016

Today I tested and escaped tags in the output of failed step in MetaStep (by using Step Object).
I think that's everything.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Sep 13, 2016

Member

Cool, then I'm merging

Member

DavertMik commented Sep 13, 2016

Cool, then I'm merging

@DavertMik DavertMik merged commit 5c8498d into Codeception:2.2 Sep 13, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

@Naktibalda Naktibalda deleted the Naktibalda:debug-display-raw-tags branch Dec 31, 2016

chris1312 added a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017

Escape tags in debug output (#3507)
* Don't interpret tags in output of codecept_debug()

Fixes #3495

* Don't interpret tags in diff output

* Don't interpret tags in certain parts of error output and step output

* Deleted Console::printSkippedTest method, because nothing used it anymore

* Escape tags in failed step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment