New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrorHandler fix #3572

Merged
merged 1 commit into from Oct 26, 2016

Conversation

Projects
None yet
3 participants
@positronium
Contributor

positronium commented Oct 3, 2016

Call registerDeprecationErrorHandler method and register_shutdown_function on first SuiteEvent only.
Fixes #3571.

ErrorHandler fix
Call registerDeprecationErrorHandler method on first SuiteEvent only
@@ -39,11 +44,16 @@ public function handle(SuiteEvent $e)
$this->errorLevel = eval("return {$settings['error_level']};");
}
error_reporting($this->errorLevel);
if (self::$initialized) {

This comment has been minimized.

@sergeyklay

sergeyklay Oct 3, 2016

Member

Please don't introduce new static properties if it's not necessary

@sergeyklay

sergeyklay Oct 3, 2016

Member

Please don't introduce new static properties if it's not necessary

This comment has been minimized.

@DavertMik

DavertMik Oct 7, 2016

Member

@sergeyklay do you have other ideas?

@DavertMik

DavertMik Oct 7, 2016

Member

@sergeyklay do you have other ideas?

This comment has been minimized.

@positronium

positronium Oct 14, 2016

Contributor

set_error_handler() acts globally, and I think a flag related with it also must be "global".
I just fixed a work-stopping issue for myself and appreciate a more sophisticated solution.

@positronium

positronium Oct 14, 2016

Contributor

set_error_handler() acts globally, and I think a flag related with it also must be "global".
I just fixed a work-stopping issue for myself and appreciate a more sophisticated solution.

This comment has been minimized.

@sergeyklay

sergeyklay Oct 16, 2016

Member

$this->initialized

@sergeyklay

sergeyklay Oct 16, 2016

Member

$this->initialized

This comment has been minimized.

@DavertMik

DavertMik Oct 16, 2016

Member

it was done by the same manner as self::$stopped. Can we make $stopped to be instance variable as well?
Won't it break anything?

@DavertMik

DavertMik Oct 16, 2016

Member

it was done by the same manner as self::$stopped. Can we make $stopped to be instance variable as well?
Won't it break anything?

@DavertMik DavertMik merged commit b64f4f4 into Codeception:2.2 Oct 26, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Oct 26, 2016

Member

Thanks, I will do additional improvements

Member

DavertMik commented Oct 26, 2016

Thanks, I will do additional improvements

chris1312 added a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017

ErrorHandler fix (#3572)
Call registerDeprecationErrorHandler method on first SuiteEvent only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment