Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close db connections when running haveFixtures Yii2: pull to v2.2 #3586

Merged
merged 1 commit into from Oct 10, 2016
Merged

close db connections when running haveFixtures Yii2: pull to v2.2 #3586

merged 1 commit into from Oct 10, 2016

Conversation

pchapl
Copy link
Contributor

@pchapl pchapl commented Oct 6, 2016

fixes #3456

@Naktibalda
Copy link
Member

Please add isset(\Yii::$app) condition just like in
just like in https://github.com/Codeception/Codeception/pull/3579/files

refs Codeception#3456 \Codeception\TestCase\Test does not close datab…
713dae2 
…ase connection when running haveFixtures on Yii2

Close db connections if exists after Yii2-tests (\Codeception\Module\Yii2::_after)
@pchapl pchapl force-pushed the 3456_codeception_testCase_test_does_not_close_db_conn_running_have_fixtures_yii2_ branch from 0f42e72 to 713dae2 Compare October 6, 2016 10:24
@pchapl
Copy link
Contributor Author

pchapl commented Oct 6, 2016

add isset(\Yii::$app) - done

@samdark samdark added the Yii label Oct 7, 2016
@DavertMik
Copy link
Member

Thanks!

@DavertMik DavertMik merged commit aee4a74 into Codeception:2.2 Oct 10, 2016
chris1312 pushed a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017
@pchapl
refs Codeception#3456 \Codeception\TestCase\Test does not close datab…
5b76e25 
…ase connection when running haveFixtures on Yii2 (Codeception#3586)

Close db connections if exists after Yii2-tests (\Codeception\Module\Yii2::_after)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pchapl @Naktibalda @DavertMik @samdark