New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close db connections when running haveFixtures Yii2: pull to v2.2 #3586

Merged
merged 1 commit into from Oct 10, 2016

Conversation

Projects
None yet
4 participants
@Ni-san
Contributor

Ni-san commented Oct 6, 2016

fixes #3456

@samdark

samdark approved these changes Oct 6, 2016

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Oct 6, 2016

Member

Please add isset(\Yii::$app) condition just like in
just like in https://github.com/Codeception/Codeception/pull/3579/files

Member

Naktibalda commented Oct 6, 2016

Please add isset(\Yii::$app) condition just like in
just like in https://github.com/Codeception/Codeception/pull/3579/files

p.chapl
refs #3456 \Codeception\TestCase\Test does not close database connect…
…ion when running haveFixtures on Yii2

Close db connections if exists after Yii2-tests (\Codeception\Module\Yii2::_after)
@Ni-san

This comment has been minimized.

Show comment
Hide comment
@Ni-san

Ni-san Oct 6, 2016

Contributor

add isset(\Yii::$app) - done

Contributor

Ni-san commented Oct 6, 2016

add isset(\Yii::$app) - done

@samdark samdark added the Yii label Oct 7, 2016

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Oct 10, 2016

Member

Thanks!

Member

DavertMik commented Oct 10, 2016

Thanks!

@DavertMik DavertMik merged commit aee4a74 into Codeception:2.2 Oct 10, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

chris1312 added a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017

refs #3456 \Codeception\TestCase\Test does not close database connect…
…ion when running haveFixtures on Yii2 (#3586)

Close db connections if exists after Yii2-tests (\Codeception\Module\Yii2::_after)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment