New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to return right value Yii1::getDomainRegex #3597

Merged
merged 1 commit into from Oct 15, 2016

Conversation

Projects
None yet
4 participants
@amashigeseiji
Contributor

amashigeseiji commented Oct 10, 2016

fix #3581

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Oct 14, 2016

Member

@amashigeseiji this PR can't be merged because semaphoreci didn't report status.

One way to restart it is to git rebase.

git rebase 2.2 fix-to-return-right-value-getDomainRegex
git push -f

Could you do that?

Member

Naktibalda commented Oct 14, 2016

@amashigeseiji this PR can't be merged because semaphoreci didn't report status.

One way to restart it is to git rebase.

git rebase 2.2 fix-to-return-right-value-getDomainRegex
git push -f

Could you do that?

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Oct 15, 2016

Member

Thanks

Member

Naktibalda commented Oct 15, 2016

Thanks

@Naktibalda Naktibalda merged commit f108108 into Codeception:2.2 Oct 15, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
@nathanphan

This comment has been minimized.

Show comment
Hide comment
@nathanphan

nathanphan Oct 16, 2016

thanks guys

thanks guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment