Improved message for connection failures in WebDriver #3603

Merged
merged 1 commit into from Oct 13, 2016

Conversation

Projects
None yet
2 participants
@DavertMik
Member

DavertMik commented Oct 12, 2016

Some additional improvements to #3534

  • Changed how errors are added for in test.before listeners
  • Fixed AngularJS + WebDriver compatibility
  • Selenium connection failure message is single line now

selection_155

* Improved message for connection failures in WebDriver
* Changed how errors are added for in test.before listeners
 * Fixed AngularJS + WebDriver compat
@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Oct 12, 2016

Member

@eXorus are you ok with this improvements?

Member

DavertMik commented Oct 12, 2016

@eXorus are you ok with this improvements?

@eXorus

This comment has been minimized.

Show comment
Hide comment
@eXorus

eXorus Oct 13, 2016

Contributor

@DavertMik I did some tests and it seems to work fine.

Contributor

eXorus commented Oct 13, 2016

@DavertMik I did some tests and it seems to work fine.

@eXorus

eXorus approved these changes Oct 13, 2016

@DavertMik DavertMik merged commit 5f7ce11 into 2.2 Oct 13, 2016

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

@DavertMik DavertMik deleted the webdriver-error-improv branch Oct 13, 2016

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Oct 13, 2016

Member

Thanks

Member

DavertMik commented Oct 13, 2016

Thanks

chris1312 added a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017

* Improved message for connection failures in WebDriver (#3603)
* Changed how errors are added for in test.before listeners
 * Fixed AngularJS + WebDriver compat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment