Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add seedings capabilities (#3552) #3625
for the first comment in #3552 with the ability to choose what seeds we want to run
I have a few comments and questions.
Firstly, can you submit your PR to the 2.2 branch instead of master?
I also think this implementation is a bit too simple. I think it should at least be possible to specify a class name of the seeder you want to run. This way you can have different seeders for different environments. I think a good way to implement this is by adding another configuration option
I also think
Lastly, I think you should move the code outside the if statement that checks if migrations should run. This way you are not required to run the migrations, which provides more flexibility. You could for example use the DB module to setup your database and then run your database seeders via the Laravel5 module.
Let me know what you think.
Yes i can change the branche of my PR to 2.2
Hum you are right for the multiple seeder option,
For the options names, it's okay too, i will change it for better names.
And sorry again for the PR into the master, i was a bit confused, i didn't see the changes in this file, i had contribued to Laravel5 module but before this commit