fix 3392: normalize namespace in DI getter #3633

Merged
merged 1 commit into from Oct 24, 2016

Conversation

Projects
None yet
4 participants
@Mitrichius
Contributor

Mitrichius commented Oct 22, 2016

Fix #3392
Caused by 27d9994 . Namespace normalizing was added into instantiate method, but missed in getter.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Oct 22, 2016

Member

@janhenkgerritsen you was the last who fixed ModuleContainer, which is the main consumer of DI. Are you ok with this change?

Member

DavertMik commented Oct 22, 2016

@janhenkgerritsen you was the last who fixed ModuleContainer, which is the main consumer of DI. Are you ok with this change?

@janhenkgerritsen

This comment has been minimized.

Show comment
Hide comment
@janhenkgerritsen

janhenkgerritsen Oct 24, 2016

Contributor

The ModuleContainer only uses the instantiate method of the Di class, so this change should not cause any problems.

Contributor

janhenkgerritsen commented Oct 24, 2016

The ModuleContainer only uses the instantiate method of the Di class, so this change should not cause any problems.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Oct 24, 2016

Member

Ok, thanks!

Member

DavertMik commented Oct 24, 2016

Ok, thanks!

@DavertMik DavertMik merged commit 611a842 into Codeception:2.2 Oct 24, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

chris1312 added a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment