New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongofill support #3641

Merged
merged 1 commit into from Oct 26, 2016

Conversation

Projects
None yet
2 participants
@hlogeon
Contributor

hlogeon commented Oct 25, 2016

If someone are using MongoDb with PHP7 or HHVM, he forced to use mongofill package(https://github.com/mongofill/mongofill). Mongofill has class MongoClient in the root namespace but it does't means that it's using legacy mongo driver instead of current mongodb. In order to make it work with Codeception MongoDB module I changed the way you check if user uses legacy driver by adding additional condition. So if there is \MongoClient class and there is no mongofill substring in its version -> use legacy mode. Normal mode otherwise.
Before fixing that cleaning of the database didn't work and I've got errors on duplicate keys every test which were using db.

@hlogeon

This comment has been minimized.

Show comment
Hide comment
@hlogeon

hlogeon Oct 25, 2016

Contributor

By the way I would like to ask what should I do to add Doctrine ODM(for MongoDB) as a core module of Codeception? I mean that I already made it and want to add it to this repository

Contributor

hlogeon commented Oct 25, 2016

By the way I would like to ask what should I do to add Doctrine ODM(for MongoDB) as a core module of Codeception? I mean that I already made it and want to add it to this repository

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Oct 26, 2016

Member

Thanks! Looks good, probably I will mention mongofill in docs for MongoDb

Doctrine ODM(for MongoDB) as a core module of Codeception

That would be great! 👍
Please send Pull Request

Member

DavertMik commented Oct 26, 2016

Thanks! Looks good, probably I will mention mongofill in docs for MongoDb

Doctrine ODM(for MongoDB) as a core module of Codeception

That would be great! 👍
Please send Pull Request

@DavertMik DavertMik merged commit 36b441c into Codeception:2.2 Oct 26, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

chris1312 added a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment