Added procesing for native url formats of Yii2 #3725

Merged
merged 5 commits into from Nov 14, 2016

Projects

None yet

5 participants

@githubjeka
Contributor

For expample I can't use now:

 $I->sendAjaxPostRequest( [/*...*/], $dataPost); 

This fix allow to do this

@githubjeka githubjeka Added procesing for native url formats of Yii2
c25f106
src/Codeception/Module/Yii2.php
+
+ /**
+ * To support to use the behavior of urlManager component
+ * for the methods like this: amOnPage(), sendAjaxRequest() and etc.
@Nitpick-CI
Nitpick-CI Nov 11, 2016

Whitespace found at end of line

@githubjeka
githubjeka Nov 11, 2016 Contributor

So sorry

@githubjeka githubjeka Deleted whitespace for love with bots. Forever.
214e011
src/Codeception/Module/Yii2.php
+ * @param bool $changeHistory
+ * @return mixed
+ */
+ protected function clientRequest($method, $uri, array $parameters = array(), array $files = array(), array $server = array(), $content = null, $changeHistory = true)
@sergeyklay
sergeyklay Nov 11, 2016 Member

Use short syntax

protected function clientRequest($method, $uri, array $parameters = [], array $files = [], array $server = [], $content = null, $changeHistory = true)

we are in the 21st century

@githubjeka
githubjeka Nov 11, 2016 Contributor

I just copied

githubjeka added some commits Nov 11, 2016
@githubjeka githubjeka Added syntax from 21st century.
7d2c120
@githubjeka githubjeka Added syntax from 21st century.
4dc8892
@githubjeka
Contributor

Have you any tests for the Yii2 module?

@DavertMik
Member

@githubjeka yes, we run test of yii-basic app

@githubjeka githubjeka Update CHANGELOG.md
6958454
@DavertMik
Member

Thanks!

@DavertMik DavertMik merged commit b34f392 into Codeception:2.2 Nov 14, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
@githubjeka githubjeka deleted the githubjeka:patch-2 branch Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment