Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Laravel5] Added vendor_dir option #3775

Merged
merged 1 commit into from Nov 28, 2016
Merged

Conversation

@AdrianSkierniewski
Copy link
Contributor

@AdrianSkierniewski AdrianSkierniewski commented Nov 28, 2016

Hi,

I've added this option to cover the case when I want to test Laravel package separately. To do that, I'm using orchestra/testbench to bootstrap simple Laravel app. In my example, I want to use my package vendor dir instead orchestra/testbench/fixture/vendor.

By the way, why package name is set to codeception/base instead codeception/codeception in composer.json? I had some problems with installing my forked version to test if everything works as expected :)

@janhenkgerritsen janhenkgerritsen merged commit e3e1e52 into Codeception:2.2 Nov 28, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
@janhenkgerritsen
Copy link
Contributor

@janhenkgerritsen janhenkgerritsen commented Nov 28, 2016

Thanks for the PR!

As for you question about the package name, can you answer that one @DavertMik?

@AdrianSkierniewski AdrianSkierniewski deleted the AdrianSkierniewski:laravel5-module-added-vendor-dir-option branch Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.