New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception WebDriver not connected and Yii2 enabled #3876

Merged
merged 1 commit into from Dec 27, 2016

Conversation

Projects
None yet
3 participants
@margori
Contributor

margori commented Dec 26, 2016

I this exception while WebDriver and Yii2 enabled, but WebDriver not connected since I forgot to start it.

  [Symfony\Component\Debug\Exception\FatalThrowableError]  
  Call to a member function resetPersistentVars() on null 

Exception trace:
 () at /home/[...]/vendor/codeception/codeception/src/Codeception/Module/Yii2.php:221
 Codeception\Module\Yii2->_after() at /home/[...]/vendor/codeception/codeception/src/Codeception/Subscriber/Module.php:68

acceptance.suite.yml:

class_name: AcceptanceTester
modules:
    enabled:
        - WebDriver:
            url: http://localhost/app/web
            browser: chrome
            restart: false
            window_size: 1360x768
        - Yii2:
            part: init

@samdark samdark added the Yii label Dec 27, 2016

@samdark

This comment has been minimized.

Show comment
Hide comment
@samdark

samdark Dec 27, 2016

Collaborator

Looks fine to me. @DavertMik is there any case when the check would be bad?

Collaborator

samdark commented Dec 27, 2016

Looks fine to me. @DavertMik is there any case when the check would be bad?

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Dec 27, 2016

Member

Everything looks good. Thank you!

Member

DavertMik commented Dec 27, 2016

Everything looks good. Thank you!

@DavertMik DavertMik merged commit 2e08450 into Codeception:2.2 Dec 27, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

chris1312 added a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment