[2.2] Support php files in ParamsLoader.php #3914

Merged
merged 1 commit into from Jan 16, 2017

Conversation

Projects
None yet
2 participants
@arrilot
Contributor

arrilot commented Jan 15, 2017

My use case: In a project we use simple .env.php file instead of vlucas/phpdotenv and want to load params (specifically APP_URL) from it instead of duplicating configs.

It also fixes a bug when trying to load params from .env.yml and .env.ini results in an error "vlucas/phpdotenv library is required to parse .env files." which makes little sense to me.

@arrilot arrilot changed the title from [2.2] Support php files in ParamsLoader.php [WIP] to [2.2] Support php files in ParamsLoader.php Jan 15, 2017

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Jan 16, 2017

Member

Thanks for this feature and bigfix. I will update documentation for adding PHP files as param storage

Member

DavertMik commented Jan 16, 2017

Thanks for this feature and bigfix. I will update documentation for adding PHP files as param storage

@DavertMik DavertMik merged commit 565f7ed into Codeception:2.2 Jan 16, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

@arrilot arrilot deleted the arrilot:params_loader branch Jan 16, 2017

chris1312 added a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment