New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #3961 (removed bad changes after #3834) #3973

Merged
merged 1 commit into from Feb 3, 2017

Conversation

Projects
None yet
3 participants
@iRipVanWinkle
Contributor

iRipVanWinkle commented Jan 31, 2017

I think issue #3834 need reopen and will research

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Jan 31, 2017

Member

Have you seen #3968 ?

Member

Naktibalda commented Jan 31, 2017

Have you seen #3968 ?

@iRipVanWinkle

This comment has been minimized.

Show comment
Hide comment
@iRipVanWinkle

iRipVanWinkle Jan 31, 2017

Contributor

@Naktibalda yes i have seen it. The #3968 will not fix #3961 and I think the need in the #3968 appeared after merged #3834

Contributor

iRipVanWinkle commented Jan 31, 2017

@Naktibalda yes i have seen it. The #3968 will not fix #3961 and I think the need in the #3968 appeared after merged #3834

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Feb 3, 2017

Member

Yes, thanks. I merged that one by mistake, sure transaction should be rolled back between tests only

Member

DavertMik commented Feb 3, 2017

Yes, thanks. I merged that one by mistake, sure transaction should be rolled back between tests only

@DavertMik DavertMik merged commit 4f9d4c4 into Codeception:2.2 Feb 3, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
wercker/build Wercker pipeline passed
Details

chris1312 added a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment