added `performOn` method to WebDriver #3986

Merged
merged 5 commits into from Feb 4, 2017

Conversation

Projects
None yet
2 participants
@DavertMik
Member

DavertMik commented Feb 3, 2017

Closes #3936

See attached documentation and method's reference

@DavertMik DavertMik added the WebDriver label Feb 3, 2017

@@ -0,0 +1,67 @@
+<?php
+namespace Codeception\Util;

This comment has been minimized.

@Nitpick-CI

Nitpick-CI Feb 3, 2017

There must be one blank line after the namespace declaration

@Nitpick-CI

Nitpick-CI Feb 3, 2017

There must be one blank line after the namespace declaration

+ * Creates an instance
+ * @return ActionSequence
+ */
+ public static function build() {

This comment has been minimized.

@Nitpick-CI

Nitpick-CI Feb 3, 2017

Opening brace should be on a new line

@Nitpick-CI

Nitpick-CI Feb 3, 2017

Opening brace should be on a new line

+ {
+ return $this->actions;
+ }
+}

This comment has been minimized.

@Nitpick-CI

Nitpick-CI Feb 3, 2017

Expected 1 newline at end of file; 0 found

@Nitpick-CI

Nitpick-CI Feb 3, 2017

Expected 1 newline at end of file; 0 found

@DavertMik DavertMik added this to the 2.2.9 milestone Feb 3, 2017

DavertMik added some commits Feb 3, 2017

@DavertMik DavertMik merged commit ed549a9 into 2.2 Feb 4, 2017

6 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
wercker/build Wercker pipeline passed
Details

@DavertMik DavertMik deleted the perform-on branch Feb 4, 2017

chris1312 added a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017

added `performOn` method to WebDriver (#3986)
* added `performOn` method to WebDriver

* reverted change to WebDriver's config

* unset base element whenever outside the context

* improved exceptions, and docs

* updated doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment