Fix coverage cookie check, mentioned in #2923 #4020

Merged
merged 1 commit into from Mar 8, 2017

Conversation

Projects
None yet
3 participants
@boboldehampsink
Contributor

boboldehampsink commented Feb 17, 2017

There's a double check on the same cookie.

@Naktibalda

I have no idea if it fixes anything, but the change looks correct.

@boboldehampsink

This comment has been minimized.

Show comment
Hide comment
@boboldehampsink

boboldehampsink Feb 17, 2017

Contributor

No idea either, only know that it was wrong before ;-) Coincidental notice.

Contributor

boboldehampsink commented Feb 17, 2017

No idea either, only know that it was wrong before ;-) Coincidental notice.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Feb 20, 2017

Member

Thanks. I will merge it once I get a chance to try it by myself

Member

DavertMik commented Feb 20, 2017

Thanks. I will merge it once I get a chance to try it by myself

@Naktibalda Naktibalda requested a review from DavertMik Feb 24, 2017

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Mar 8, 2017

Member

Thanks!

Member

DavertMik commented Mar 8, 2017

Thanks!

@DavertMik DavertMik merged commit 77a1e8f into Codeception:2.2 Mar 8, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
wercker/build Wercker pipeline passed
Details

@boboldehampsink boboldehampsink deleted the boboldehampsink:fix_coverage_cookie_check branch Mar 8, 2017

chris1312 added a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment