Included suite tests fixes #4063

Merged
merged 3 commits into from Mar 18, 2017

Conversation

Projects
None yet
3 participants
@DavertMik
Member

DavertMik commented Mar 16, 2017

This fixes a case where you have mixed local suites (under tests folder) and included suite from other applications (via include path).

A reproducible example with a test provided.
Fix also applied to build command

DavertMik added some commits Mar 16, 2017

fixed running tests with included suites mixed with local suites
build command updated to support mixed suites as well
Merge branch '2.2' into included-tests
# Conflicts:
#	tests/data/included/jazz/pianist/tests/_helpers/_generated/TestGuyActions.php
#	tests/data/included_w/src/bar/Sub/EwokPack/tests/_support/_generated/UnitTesterActions.php
#	tests/data/included_w/src/bar/ToastPack/tests/_support/_generated/UnitTesterActions.php
#	tests/data/included_w/src/foo/AcmePack/tests/_support/_generated/UnitTesterActions.php
@@ -0,0 +1,472 @@
+<?php //[STAMP] b822c13a1ed14d868ece1edfdbc8bd14
+namespace AcmePack\_generated;

This comment has been minimized.

@Naktibalda

Naktibalda Mar 16, 2017

Member

Please delete this file and add it to .gitignore

@Naktibalda

Naktibalda Mar 16, 2017

Member

Please delete this file and add it to .gitignore

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Mar 17, 2017

Member

Thanks, we should add a rule to ignore generated files to bootstrap template.

Member

Naktibalda commented Mar 17, 2017

Thanks, we should add a rule to ignore generated files to bootstrap template.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Mar 18, 2017

Member

Yes, we have a line like

file_put_contents('.gitignore', file_get_contents('.gitignore') . "\ntests/_output/*");

but this should be improved to include generated files. Thanks for the suggestion

Member

DavertMik commented Mar 18, 2017

Yes, we have a line like

file_put_contents('.gitignore', file_get_contents('.gitignore') . "\ntests/_output/*");

but this should be improved to include generated files. Thanks for the suggestion

@DavertMik DavertMik merged commit 91ed589 into 2.2 Mar 18, 2017

6 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
wercker/build Wercker pipeline passed
Details

@DavertMik DavertMik deleted the included-tests branch Mar 18, 2017

chris1312 added a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017

Included suite tests fixes (#4063)
* fixed running tests with included suites mixed with local suites
build command updated to support mixed suites as well

* added generated files to gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment