Fixed Issue/4059 #4071

Merged
merged 2 commits into from Mar 24, 2017

Conversation

Projects
None yet
2 participants
@Naktibalda
Member

Naktibalda commented Mar 22, 2017

Run the last statement in dump file even if it doesn't end with delimiter

Fixes #4059

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Mar 23, 2017

Member

I restarted the build on Semaphore few times but it is still failing :(

I don't know how it is related but the issue is:

1) WebDriverTest: Session snapshots
 Test  tests/web/WebDriverTest.php:testSessionSnapshots
                                                                                                                                                                                                                                                             
  [PHPUnit_Framework_Exception] Argument 1 passed to Codeception\Module\WebDriver::cookieDomainMatchesConfigUrl() must be of the type array, object given, called in /home/runner/Codeception/src/Codeception/Module/WebDriver.php on line 2721 and defined  
                                                                                                                                                           
Member

DavertMik commented Mar 23, 2017

I restarted the build on Semaphore few times but it is still failing :(

I don't know how it is related but the issue is:

1) WebDriverTest: Session snapshots
 Test  tests/web/WebDriverTest.php:testSessionSnapshots
                                                                                                                                                                                                                                                             
  [PHPUnit_Framework_Exception] Argument 1 passed to Codeception\Module\WebDriver::cookieDomainMatchesConfigUrl() must be of the type array, object given, called in /home/runner/Codeception/src/Codeception/Module/WebDriver.php on line 2721 and defined  
                                                                                                                                                           
@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Mar 23, 2017

Member

I think this is related #4073

Member

DavertMik commented Mar 23, 2017

I think this is related #4073

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Mar 24, 2017

Member

The WebDriver failure turned out to be unrelated so I'm merging

Member

DavertMik commented Mar 24, 2017

The WebDriver failure turned out to be unrelated so I'm merging

@DavertMik DavertMik merged commit eeeae37 into Codeception:2.2 Mar 24, 2017

3 of 4 checks passed

semaphoreci The build failed on Semaphore.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
wercker/build Wercker pipeline passed
Details

@Naktibalda Naktibalda deleted the Naktibalda:issue/4059 branch Apr 17, 2017

chris1312 added a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017

Fixed Issue/4059 (#4071)
* [Db] Run the last statement in file even if it doesn't end with delimiter

Fixes #4059

* Eliminated property sqltoRun
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment