[WebDriver] Fixed compatibility with facebook/webdriver 1.4.0 #4076

Merged
merged 3 commits into from Mar 24, 2017

Conversation

Projects
None yet
2 participants
@Naktibalda
Member

Naktibalda commented Mar 23, 2017

Fixes #4073

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Mar 24, 2017

Member

Awesome!

Please remove phar file from the commit. You ignored it but didn't remove it

Member

DavertMik commented Mar 24, 2017

Awesome!

Please remove phar file from the commit. You ignored it but didn't remove it

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Mar 24, 2017

Member

Ah, I see. Then everything is good.

Member

DavertMik commented Mar 24, 2017

Ah, I see. Then everything is good.

@DavertMik DavertMik merged commit bbcb4ec into Codeception:2.2 Mar 24, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
wercker/build Wercker pipeline passed
Details

@Naktibalda Naktibalda deleted the Naktibalda:facebook-webdriver-1.4.0 branch Mar 24, 2017

chris1312 added a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017

[WebDriver] Fixed compatibility with facebook/webdriver 1.4.0 (#4076)
* Fixed broken test before making more changes

* [WebDriver] Fixed compatibility with facebook/webdriver 1.4.0

Fixes #4073

* Ignore codecept.phar file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment