New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Db] loadDump reports sql statement which caused error #4120

Merged
merged 2 commits into from Apr 11, 2017

Conversation

Projects
None yet
3 participants
@Naktibalda
Member

Naktibalda commented Apr 10, 2017

This functionality was accidently broken by removal of sqlToRun property in 2.2.10
Replaces #4115

[Db] loadDump reports sql statement which caused error
This functionality was accidently broken by removal of sqlToRun property in 2.2.10
Replaces #4115
@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Apr 11, 2017

Member

Wercker build has failed because HHVM uses a different message format for PDO exceptions.
I will remove non-matching part from expected message.

Member

Naktibalda commented Apr 11, 2017

Wercker build has failed because HHVM uses a different message format for PDO exceptions.
I will remove non-matching part from expected message.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Apr 11, 2017

Member

Good. Thanks

Member

DavertMik commented Apr 11, 2017

Good. Thanks

@DavertMik DavertMik merged commit c82a621 into Codeception:2.2 Apr 11, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
wercker/build Wercker pipeline passed
Details

@Naktibalda Naktibalda deleted the Naktibalda:db-load-dump-error-message branch Apr 17, 2017

chris1312 added a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017

[Db] loadDump reports sql statement which caused error (#4120)
* [Db] loadDump reports sql statement which caused error

This functionality was accidently broken by removal of sqlToRun property in 2.2.10
Replaces #4115

* Made failing test pass on HHVM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment