New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set only host #4172

Merged
merged 2 commits into from May 8, 2017

Conversation

Projects
None yet
4 participants
@SG5
Contributor

SG5 commented Apr 26, 2017

If you have enabled pretty url and try to set only host in url

modules:
    enabled:
      - Yii1:
          appPath: ./../../public/index-test.php
          url: http://localhost/

you will get warning (and exception in error handler) strpos(): Empty needle

Allow to set only host
If you have enabled pretty url and try to set only host in url
```
modules:
    enabled:
      - Yii1:
          appPath: ./../../public/index-test.php
          url: http://localhost/
```
you will get warning (and exception in error handler) `strpos(): Empty needle`
Show outdated Hide outdated src/Codeception/Lib/Connector/Yii1.php
@@ -67,7 +67,7 @@ public function doRequest($request)
}
// Add script name to request if none
if (strpos($uriPath, $scriptName) === false) {
if ($scriptName AND strpos($uriPath, $scriptName) === false) {

This comment has been minimized.

@Nitpick-CI

Nitpick-CI Apr 26, 2017

PHP keywords must be lowercase; expected and but found AND

@Nitpick-CI

Nitpick-CI Apr 26, 2017

PHP keywords must be lowercase; expected and but found AND

@Naktibalda Naktibalda added the Yii label Apr 26, 2017

@DavertMik DavertMik requested a review from samdark Apr 26, 2017

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik May 8, 2017

Member

Thanks

Member

DavertMik commented May 8, 2017

Thanks

@DavertMik DavertMik merged commit 8bb570f into Codeception:2.2 May 8, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
wercker/build Wercker pipeline passed
Details

chris1312 added a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017

Allow to set only host (#4172)
* Allow to set only host

If you have enabled pretty url and try to set only host in url
```
modules:
    enabled:
      - Yii1:
          appPath: ./../../public/index-test.php
          url: http://localhost/
```
you will get warning (and exception in error handler) `strpos(): Empty needle`

* php keyword for CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment