New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve mongo legacy check #4178

Merged
merged 2 commits into from Apr 28, 2017

Conversation

Projects
None yet
3 participants
@retnek
Contributor

retnek commented Apr 28, 2017

Hello,

I think this is a better way for decide wich mongo have to use. If you use both legacy mongo and the current mongodb, the legacy value will be false.

Issue #4174

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Apr 28, 2017

Member

I think that your change breaks MongoDb module on HHVM, please take a look at #3641 and https://github.com/mongofill/mongofill

Member

Naktibalda commented Apr 28, 2017

I think that your change breaks MongoDb module on HHVM, please take a look at #3641 and https://github.com/mongofill/mongofill

@retnek

This comment has been minimized.

Show comment
Hide comment
@retnek

retnek Apr 28, 2017

Contributor

Good point. I fixed that.

Contributor

retnek commented Apr 28, 2017

Good point. I fixed that.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Apr 28, 2017

Member

Thanks

Member

DavertMik commented Apr 28, 2017

Thanks

@DavertMik DavertMik merged commit caf94a8 into Codeception:2.2 Apr 28, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
wercker/build Wercker pipeline passed
Details

chris1312 added a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017

improve mongo legacy check (#4178)
* improve mongo legacy check

* fix wrong result of mongofill library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment