New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongo parsing dbname #4186

Merged
merged 4 commits into from May 5, 2017

Conversation

Projects
None yet
2 participants
@retnek
Contributor

retnek commented May 2, 2017

I've made changes in the MongoDb module, because the hostname and dbname variables were got wrong values when the dsn contain any connection string option (like connectTimeoutMS).

MongoDbTest has been extended.

I reported the issue #4179 a couple of days before.

retnek added some commits Apr 28, 2017

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda May 3, 2017

Member

Your test fails occasionally:

On the first run 2 builds out of 5 failed (PHP 5.4 and 7.1) with:

1) MongoDbTest: Load dump
 Test  tests/unit/Codeception/Module/MongoDbTest.php:testLoadDump
Failed asserting that 7 matches expected 3.
#1  /home/travis/build/Codeception/Codeception/tests/unit/Codeception/Module/MongoDbTest.php:160
#2  MongoDbTest->testLoadDump
#3  /home/travis/build/Codeception/Codeception/codecept:36

I restarted both and they passed.
Then I restarted all builds and 2 out of 5 failed again (PHP 5.6 and 7.1 this time):

https://travis-ci.org/Codeception/Codeception/jobs/228062036

1) MongoDbTest: Load dump

 Test  tests/unit/Codeception/Module/MongoDbTest.php:testLoadDump
Failed asserting that 7 matches expected 2.
#1  /home/travis/build/Codeception/Codeception/tests/unit/Codeception/Module/MongoDbTest.php:160
#2  MongoDbTest->testLoadDump
#3  /home/travis/build/Codeception/Codeception/codecept:36
Member

Naktibalda commented May 3, 2017

Your test fails occasionally:

On the first run 2 builds out of 5 failed (PHP 5.4 and 7.1) with:

1) MongoDbTest: Load dump
 Test  tests/unit/Codeception/Module/MongoDbTest.php:testLoadDump
Failed asserting that 7 matches expected 3.
#1  /home/travis/build/Codeception/Codeception/tests/unit/Codeception/Module/MongoDbTest.php:160
#2  MongoDbTest->testLoadDump
#3  /home/travis/build/Codeception/Codeception/codecept:36

I restarted both and they passed.
Then I restarted all builds and 2 out of 5 failed again (PHP 5.6 and 7.1 this time):

https://travis-ci.org/Codeception/Codeception/jobs/228062036

1) MongoDbTest: Load dump

 Test  tests/unit/Codeception/Module/MongoDbTest.php:testLoadDump
Failed asserting that 7 matches expected 2.
#1  /home/travis/build/Codeception/Codeception/tests/unit/Codeception/Module/MongoDbTest.php:160
#2  MongoDbTest->testLoadDump
#3  /home/travis/build/Codeception/Codeception/codecept:36
@retnek

This comment has been minimized.

Show comment
Hide comment
@retnek

retnek May 3, 2017

Contributor

I modified the test.
I think the grabCollectionCount result is not accurate in some cases.

example

Contributor

retnek commented May 3, 2017

I modified the test.
I think the grabCollectionCount result is not accurate in some cases.

example

@Naktibalda Naktibalda merged commit f49300c into Codeception:2.2 May 5, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
wercker/build Wercker pipeline passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment