New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows use `InitDbFixture` feature #4201

Merged
merged 2 commits into from May 8, 2017

Conversation

Projects
None yet
5 participants
@leandrogehlen
Contributor

leandrogehlen commented May 8, 2017

No description provided.

Show outdated Hide outdated src/Codeception/Lib/Connector/Yii2/FixturesStore.php
public function globalFixtures()
{
return [

This comment has been minimized.

@Nitpick-CI

Nitpick-CI May 8, 2017

Line indented incorrectly; expected at least 8 spaces, found 7

@Nitpick-CI

Nitpick-CI May 8, 2017

Line indented incorrectly; expected at least 8 spaces, found 7

@samdark

samdark approved these changes May 8, 2017

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik May 8, 2017

Member

Thanks!

Member

DavertMik commented May 8, 2017

Thanks!

@DavertMik DavertMik merged commit ac1ae26 into Codeception:2.2 May 8, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
wercker/build Wercker pipeline passed
Details
@markoheijnen

This comment has been minimized.

Show comment
Hide comment
@markoheijnen

markoheijnen Jun 2, 2017

How do you now remove InitDbFixture? Or the better question, how does this work with a non-relational database like MongoDB.

How do you now remove InitDbFixture? Or the better question, how does this work with a non-relational database like MongoDB.

@leandrogehlen

This comment has been minimized.

Show comment
Hide comment
@leandrogehlen

leandrogehlen Jun 2, 2017

Contributor

The behavior is the same or yii2-codepection/DbTestCase.php#L32.

This feature just was moved to this repository

Contributor

leandrogehlen commented Jun 2, 2017

The behavior is the same or yii2-codepection/DbTestCase.php#L32.

This feature just was moved to this repository

@markoheijnen

This comment has been minimized.

Show comment
Hide comment
@markoheijnen

markoheijnen Jun 2, 2017

That could be, still new to Yii. I know my code worked before but that could have been luck. So in my case I'm using MongoDB for everything.

What I am seeing is that InitDbFixture can't be removed and so it's running also with MongoDB which doesn't have a checkIntegrity() method. So it's trying to call yii\mongodb\Command::checkIntegrity() but fails.

That could be, still new to Yii. I know my code worked before but that could have been luck. So in my case I'm using MongoDB for everything.

What I am seeing is that InitDbFixture can't be removed and so it's running also with MongoDB which doesn't have a checkIntegrity() method. So it's trying to call yii\mongodb\Command::checkIntegrity() but fails.

@leandrogehlen

This comment has been minimized.

Show comment
Hide comment
@leandrogehlen

leandrogehlen Jun 2, 2017

Contributor

@markoheijnen, you are right, the feature is not implemented in yii2-mongodb.
@samdark , I could create a option initdb to define if the InitDbFixture should be used.
What do you think?

Contributor

leandrogehlen commented Jun 2, 2017

@markoheijnen, you are right, the feature is not implemented in yii2-mongodb.
@samdark , I could create a option initdb to define if the InitDbFixture should be used.
What do you think?

chris1312 added a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017

Allows use `InitDbFixture` feature (#4201)
* Allows use `InitDbFixture` feature

* Fixes code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment