Redis module default configuration must be more foolproof. #4229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Document ( http://codeception.com/docs/modules/Redis ) and comments of module source, it says Codeception flushes the database "At the beginning of every suite" (
cleanupBefore: 'suite'
) . However default setting ofcleanupBefore
is set to "At the beginning of every test" (cleanupBefore: 'test'
), so description of documentation is not actually true.And flushing database without any attention seems dangerous behavior, so I turned default configuration to safe-side.