New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t skip empty strings in headers. #4290

Merged
merged 1 commit into from Jun 1, 2017

Conversation

Projects
None yet
4 participants
@tobiastom
Contributor

tobiastom commented May 31, 2017

This will close #4287.

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda May 31, 2017

Member

I find it ironic that it still skips empty string ''.

Member

Naktibalda commented May 31, 2017

I find it ironic that it still skips empty string ''.

@tobiastom

This comment has been minimized.

Show comment
Hide comment
@tobiastom

tobiastom May 31, 2017

Contributor

That's the intended behaviour, right?

For me I didn't see why this check is there in the first place. Either I set a header, or I delete it. When I delete it, deleteHeader will unset it.

Contributor

tobiastom commented May 31, 2017

That's the intended behaviour, right?

For me I didn't see why this check is there in the first place. Either I set a header, or I delete it. When I delete it, deleteHeader will unset it.

@Naktibalda Naktibalda changed the base branch from master to 2.3 May 31, 2017

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Jun 1, 2017

Member

Thanks!

Member

DavertMik commented Jun 1, 2017

Thanks!

@DavertMik DavertMik merged commit fdfb758 into Codeception:2.3 Jun 1, 2017

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
wercker/build Wercker pipeline failed
Details
semaphoreci The build passed on Semaphore.
Details

@tobiastom tobiastom deleted the tobiastom:bugfix/empty-header-values branch Jun 2, 2017

@tobiastom

This comment has been minimized.

Show comment
Hide comment
@tobiastom

tobiastom Jun 2, 2017

Contributor

Thanks you the merge! :-)

Contributor

tobiastom commented Jun 2, 2017

Thanks you the merge! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment