New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `andWhere` instead of `where` #4482

Merged
merged 2 commits into from Sep 5, 2017

Conversation

Projects
None yet
4 participants
@SamMousa
Collaborator

SamMousa commented Sep 4, 2017

@samdark samdark self-assigned this Sep 4, 2017

@samdark

samdark approved these changes Sep 4, 2017

@samdark samdark added the Yii label Sep 4, 2017

@samdark

This comment has been minimized.

Show comment
Hide comment
@samdark

samdark Sep 4, 2017

Collaborator

I confirm the change is correct.

Collaborator

samdark commented Sep 4, 2017

I confirm the change is correct.

@SamMousa

This comment has been minimized.

Show comment
Hide comment
@SamMousa

SamMousa Sep 5, 2017

Collaborator

It seems tests are broken by another cause.

Collaborator

SamMousa commented Sep 5, 2017

It seems tests are broken by another cause.

@Naktibalda Naktibalda changed the base branch from master to 2.3 Sep 5, 2017

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Sep 5, 2017

Member

The cause was that you made a PR to master branch, bugfixes and backwards compatible features should be merge to the current active branch (2.3).

Member

Naktibalda commented Sep 5, 2017

The cause was that you made a PR to master branch, bugfixes and backwards compatible features should be merge to the current active branch (2.3).

@SamMousa

This comment has been minimized.

Show comment
Hide comment
@SamMousa

SamMousa Sep 5, 2017

Collaborator

My bad. Hmm, I fixed it but noticed after that you fixed it as well, didn't know you could change my PR's target branch :O

Collaborator

SamMousa commented Sep 5, 2017

My bad. Hmm, I fixed it but noticed after that you fixed it as well, didn't know you could change my PR's target branch :O

@SamMousa SamMousa closed this Sep 5, 2017

@SamMousa SamMousa reopened this Sep 5, 2017

@samdark samdark merged commit 1dca8f3 into Codeception:2.3 Sep 5, 2017

3 of 4 checks passed

wercker/build Wercker pipeline failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
@samdark

This comment has been minimized.

Show comment
Hide comment
@samdark

samdark Sep 5, 2017

Collaborator

Merged. Thank you!

Collaborator

samdark commented Sep 5, 2017

Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment