Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject exception file and line number frame into stack trace #4491

Merged
merged 1 commit into from Sep 11, 2017

Conversation

@rhl-jfm
Copy link
Contributor

@rhl-jfm rhl-jfm commented Sep 8, 2017

This mirrors what PHPUnit does when filtering stack traces (since 2008).

It inject a "fake" frame into the top of the stack trace with the actual line where the unexpected exception was thrown. This makes the stack traces much more usable. Fixes #3200.

@DavertMik
Copy link
Member

@DavertMik DavertMik commented Sep 11, 2017

Thanks for implementing this nice lifehack!

@DavertMik DavertMik merged commit 0e6814c into Codeception:2.3 Sep 11, 2017
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
wercker/build Wercker pipeline passed
Details
@Naktibalda
Copy link
Member

@Naktibalda Naktibalda commented Sep 25, 2017

It isn't a lifehack, it is really important bugfix.
Thanks for it.

By the way, I just discovered that the most complete stacktrace is produced by --debug method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.