New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cest generator: suite namespaces #4525

Merged
merged 4 commits into from Sep 28, 2017

Conversation

Projects
None yet
4 participants
@pohnean
Contributor

pohnean commented Sep 21, 2017

Hi I've added support to allow for suites to have different namespaces from the main configuration namespace, while the actors still use the main namespace.

The specific use case for me was that I wanted to have a different namespace for each of my test suites, but still have the Actors be in the /tests/_support folder.

Sample suite configuration:

suite_namespace: 'tests\unit'
class_name: 'UnitTester'

Sample global configuration:

namespace: 'tests'

This pull request solves that by adding a new suite_namespace setting in the suite. This should not cause any breaking changes.

Tai Poh Nean
Updating Cest generator to allow for actors with different namespace …
…from suite or main configuration's namespace.

Tai Poh Nean added some commits Sep 21, 2017

Tai Poh Nean
Tai Poh Nean

@pohnean pohnean changed the title from Cest generator: actors with different namespace to Cest generator: suite namespaces Sep 22, 2017

Tai Poh Nean
@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Sep 22, 2017

Member

I like the idea, I like the implementation but I'm not so sure about the name.

suite_namespace is so general term, I'm not so sure it is very descriptive.

tests_namespace may sound a bit better. As we set a namespace for test classes...

but I'm not sure, anyway

Member

DavertMik commented Sep 22, 2017

I like the idea, I like the implementation but I'm not so sure about the name.

suite_namespace is so general term, I'm not so sure it is very descriptive.

tests_namespace may sound a bit better. As we set a namespace for test classes...

but I'm not sure, anyway

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Sep 28, 2017

Member

I didn't get better ideas so far so I'm about to merge this as it is

Member

DavertMik commented Sep 28, 2017

I didn't get better ideas so far so I'm about to merge this as it is

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Sep 28, 2017

Member

Ok, I will update the documentation. Thanks, @pohnean

Member

DavertMik commented Sep 28, 2017

Ok, I will update the documentation. Thanks, @pohnean

@DavertMik DavertMik merged commit 32023a9 into Codeception:2.3 Sep 28, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
wercker/build Wercker pipeline passed
Details
@pohnean

This comment has been minimized.

Show comment
Hide comment
@pohnean

pohnean Sep 29, 2017

Contributor

Sweet! 👍

Contributor

pohnean commented Sep 29, 2017

Sweet! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment