New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header Enhancements #4541

Merged
merged 2 commits into from Sep 28, 2017

Conversation

Projects
None yet
3 participants
@bnpatel1990
Contributor

bnpatel1990 commented Sep 27, 2017

Updates to Fix Underscore Bug in HTTP Headers #4520

So this is an enhancement to accommodate special chars in the headers like underscore.

I can now pass in a header with html encoded character exampleclient_id and later during header extraction decode the html character client_id.

The html decoding will only work if encoded chars are passed in else the functionality is unaffected.

Bhavdeep Patel Bhavdeep Patel
@DavertMik

Looks good to me. @Naktibalda what do you think?

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Sep 27, 2017

Member

This workaround should be documented somewhere.

Member

Naktibalda commented Sep 27, 2017

This workaround should be documented somewhere.

@bnpatel1990

This comment has been minimized.

Show comment
Hide comment
@bnpatel1990

bnpatel1990 Sep 27, 2017

Contributor

I can update the required documents. And make another commit.

Contributor

bnpatel1990 commented Sep 27, 2017

I can update the required documents. And make another commit.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Sep 28, 2017

Member

I'm not so sure where to put it so it would be visible.
Is that feature used with haveHttpHeader? If so we should put it into the documentation section of InnerBrowser class for haveHttpHeader method http://codeception.com/docs/modules/PhpBrowser#haveHttpHeader

Member

DavertMik commented Sep 28, 2017

I'm not so sure where to put it so it would be visible.
Is that feature used with haveHttpHeader? If so we should put it into the documentation section of InnerBrowser class for haveHttpHeader method http://codeception.com/docs/modules/PhpBrowser#haveHttpHeader

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Sep 28, 2017

Member

@DavertMik good idea.
@bnpatel1990 Please document this feature in the docblock of InnerBrowser::haveHttpHeader.

Member

Naktibalda commented Sep 28, 2017

@DavertMik good idea.
@bnpatel1990 Please document this feature in the docblock of InnerBrowser::haveHttpHeader.

@bnpatel1990

This comment has been minimized.

Show comment
Hide comment
@bnpatel1990

bnpatel1990 Sep 28, 2017

Contributor

Yeah i use it in inner browser havehttpheader. Will do in awhile and push a commit

Contributor

bnpatel1990 commented Sep 28, 2017

Yeah i use it in inner browser havehttpheader. Will do in awhile and push a commit

@bnpatel1990

This comment has been minimized.

Show comment
Hide comment
@bnpatel1990

bnpatel1990 Sep 28, 2017

Contributor

Docs Updated @Naktibalda @DavertMik

Contributor

bnpatel1990 commented Sep 28, 2017

Docs Updated @Naktibalda @DavertMik

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Sep 28, 2017

Member

Thanks!

Member

DavertMik commented Sep 28, 2017

Thanks!

@DavertMik DavertMik merged commit 3b3897e into Codeception:2.3 Sep 28, 2017

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
semaphoreci The build is pending on Semaphore.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
wercker/build Wercker pipeline passed
Details

@Naktibalda Naktibalda referenced this pull request Feb 13, 2018

Open

HTTP header problem #4810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment