New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow .tgz extensions to pass validation #4611

Merged
merged 1 commit into from Nov 9, 2017

Conversation

Projects
None yet
2 participants
@Lukazar
Contributor

Lukazar commented Nov 9, 2017

.tgz is a valid extension.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Nov 9, 2017

Member

Thanks. Good addition.

This line was not really nice but with this patch it will look really ugly 😢

 if (strlen($this->dumpFile) <= 7 || (substr($this->dumpFile, -7) !== '.tar.gz' && substr($this->dumpFile, -4) !== '.tgz')) {

Could you think how to simplify this condition check so it would look nicer?

Member

DavertMik commented Nov 9, 2017

Thanks. Good addition.

This line was not really nice but with this patch it will look really ugly 😢

 if (strlen($this->dumpFile) <= 7 || (substr($this->dumpFile, -7) !== '.tar.gz' && substr($this->dumpFile, -4) !== '.tgz')) {

Could you think how to simplify this condition check so it would look nicer?

@DavertMik

One more update pls

Show outdated Hide outdated src/Codeception/Module/MongoDb.php
Luke Jones

@DavertMik DavertMik merged commit f51c5c8 into Codeception:2.3 Nov 9, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
wercker/build Wercker pipeline passed
Details

@Lukazar Lukazar deleted the Lukazar:allow_tgz_ext branch Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment