New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-4663 fixed signature in DummyCodeCoverage::stop #4665

Merged
merged 1 commit into from Dec 7, 2017

Conversation

Projects
None yet
5 participants
@network-spy

network-spy commented Dec 6, 2017

Need to add 4th parameter "$ignoreForceCoversAnnotation = false" in DummyCodeCoverage::stop method for keeping signature from "SebastianBergmann\CodeCoverage\CodeCoverage"

Fixed error:
" Declaration of Codeception\Coverage\DummyCodeCoverage::stop($append = true,
$linesToBeCovered = Array, array $linesToBeUsed = Array) should be compati
ble with SebastianBergmann\CodeCoverage\CodeCoverage::stop($append = true,
$linesToBeCovered = Array, array $linesToBeUsed = Array, $ignoreForceCovers
Annotation = false)"

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Dec 7, 2017

Member

You guys confused me. Are you 2 different people or 2 accounts of the same person?

Member

Naktibalda commented Dec 7, 2017

You guys confused me. Are you 2 different people or 2 accounts of the same person?

@Naktibalda Naktibalda merged commit 75a1f48 into Codeception:2.3 Dec 7, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
wercker/build Wercker pipeline passed
Details
@enumag

This comment has been minimized.

Show comment
Hide comment
@enumag

enumag Dec 8, 2017

Member

@Naktibalda Can we have a new release tagged? This causes all my libraries to fail.

EDIT: By the way later on there will be one more problem. In phpunit/php-code-coverage 6.0 the parent class will be final.

Member

enumag commented Dec 8, 2017

@Naktibalda Can we have a new release tagged? This causes all my libraries to fail.

EDIT: By the way later on there will be one more problem. In phpunit/php-code-coverage 6.0 the parent class will be final.

@NicolasCARPi

This comment has been minimized.

Show comment
Hide comment
@NicolasCARPi

NicolasCARPi Dec 9, 2017

While waiting for a new version to be released, posting this to help others with Scrutinizer-ci.com issues:

tests:
    before:
         - sed -ie "s/BeUsed = \[\]/BeUsed = \[\], \$ignoreForceCoversAnnotation = false/" /home/scrutinizer/build/vendor/codeception/codeception/src/Codeception/Coverage/DummyCodeCoverage.php'

It's the most simple way I found to make the tests work again ;)

NicolasCARPi commented Dec 9, 2017

While waiting for a new version to be released, posting this to help others with Scrutinizer-ci.com issues:

tests:
    before:
         - sed -ie "s/BeUsed = \[\]/BeUsed = \[\], \$ignoreForceCoversAnnotation = false/" /home/scrutinizer/build/vendor/codeception/codeception/src/Codeception/Coverage/DummyCodeCoverage.php'

It's the most simple way I found to make the tests work again ;)

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Dec 9, 2017

Member

@enumag I'm working on new release. Sooooon!

Member

DavertMik commented Dec 9, 2017

@enumag I'm working on new release. Sooooon!

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Dec 10, 2017

Member

It would be easier to restrict PHPUnit to version before this change in composer.json

Member

Naktibalda commented Dec 10, 2017

It would be easier to restrict PHPUnit to version before this change in composer.json

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Dec 10, 2017

Member

That "final" change is a dirty play.
And it will come with PHPUnit 7 which will have it's own batch of incompatible changes.

It would be good to cut off dependency on PHPUnit.

Member

Naktibalda commented Dec 10, 2017

That "final" change is a dirty play.
And it will come with PHPUnit 7 which will have it's own batch of incompatible changes.

It would be good to cut off dependency on PHPUnit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment