New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descriptor: getTestSignatureUnique #4673

Merged
merged 7 commits into from Dec 9, 2017

Conversation

Projects
None yet
3 participants
@Tenzian
Contributor

Tenzian commented Dec 9, 2017

Add Descriptor::getTestSignatureUnique(), to create unique names for tests using examples where Descriptor::getTestSignature() is not unique.

Add use of the new unique descriptor to implementations of PageSourceSaver and ScreenshotSaver where filenames are being created to provide a unique filename for each failure.

Fixes #4672

Tenzian added some commits Nov 16, 2017

Test\Descriptor: getTestSignatureUnique
Fixes #4672

- add Descriptor::getTestSignatureUnique

Replace getTestSignature in implementations of PageSourceSaver & ScreenshotSaver
where filenames are being created

- use getTestSignatureUnique in Lib\InnerBrowser
- use getTestSignatureUnique in Module\WebDriver
@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Dec 9, 2017

Member

That's a really good idea. Thanks for implementing it!

Member

DavertMik commented Dec 9, 2017

That's a really good idea. Thanks for implementing it!

@DavertMik DavertMik merged commit 003e025 into Codeception:2.3 Dec 9, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
wercker/build Wercker pipeline passed
Details

@Tenzian Tenzian deleted the Tenzian:Descriptor_getTestSignatureUnique branch Dec 11, 2017

@marcovtwout

This comment has been minimized.

Show comment
Hide comment
@marcovtwout

marcovtwout Jul 19, 2018

Contributor

@Tenzian this change introduced #4913

Contributor

marcovtwout commented Jul 19, 2018

@Tenzian this change introduced #4913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment