Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont rollback outside of a transaction #496

Merged
merged 1 commit into from Aug 21, 2013

Conversation

Projects
None yet
2 participants
@sillylogger
Copy link
Contributor

commented Aug 20, 2013

On assertion failures Codeception/Module/Dbh.php:69 will try to rollback a transaction regardless as to whether one is active (may have been killed by an assertion failure) and then it throws the PDOException... and tests abort. This can be prevented by checking to see if there is a current transaction before rolling back.

@sillylogger

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2013

Hrrm, consistently failing with the Facebook API test, the tests that runs immediately after my change.. suggests I broke something... looking into it.

@DavertMik

This comment has been minimized.

Copy link
Member

commented Aug 21, 2013

Not you :)
Yep, looks like Facebook closed its API from testing or smth like that.

DavertMik added a commit that referenced this pull request Aug 21, 2013

Merge pull request #496 from sillylogger/rollback_transactions
dont rollback outside of a transaction

@DavertMik DavertMik merged commit 8576038 into Codeception:1.6 Aug 21, 2013

1 check failed

default The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.