Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added simple wait method #519

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@allmyitjason
Copy link
Contributor

commented Aug 31, 2013

No description provided.

@DavertMik

This comment has been minimized.

Copy link
Member

commented Sep 2, 2013

How do you think, Is this really that useful? Especially done not via WebDriver but with sleep.
I mean do you have real life cases you needed that?

@allmyitjason

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2013

I looked at using the web driver wait method but it requires an until parameter. This is the same wait code pulled from that function just with no condition. Hope that makes sense.

On 03/09/2013, at 12:38 AM, Michael Bodnarchuk notifications@github.com wrote:

How do you think, Is this really that useful? Especially done not via WebDriver but with sleep.
I mean do you have real life cases you needed that?


Reply to this email directly or view it on GitHub.

@DavertMik

This comment has been minimized.

Copy link
Member

commented Sep 7, 2013

@allmyitjason Sorry, I left your PRs pending. I think I will implement wait method by myself.
Let's wait for the first release of php-webdriver to move on with its implementation.
Thanks for your additions. The more complete bindings will be, the more cool actions we can implement.

@DavertMik DavertMik closed this Sep 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.