#5328 adds phalcon version 3.4.x module #5329
Conversation
… adapter based on the internal phalcon version - changes private accessors for memory session - removes all fluff for memory-session override
src/Codeception/Module/Phalcon.php
Outdated
| /** | ||
| * @return string | ||
| */ | ||
| private function getMemorySessionForVersion() { |
There was a problem hiding this comment.
Opening brace should be on a new line
| */ | ||
| private function getMemorySessionForVersion() { | ||
| if (strpos(\Phalcon\Version::get(), '3.4') !== false) { | ||
| return PhalconConnector\MemorySession34x::class; |
There was a problem hiding this comment.
This class will work with Phalcon 4.x too, right?
It would be better to use version_compare
version_compare(\Phalcon\Version::get(), '3.4.0') >= 0)
There was a problem hiding this comment.
It's unclear if it does work with 4.x I'll compile and test it to check. Good point though.
There was a problem hiding this comment.
It is more likely to work than the old class.
There was a problem hiding this comment.
yes :D probability says it's likely. still if I don't need heuristics I won't use them :) 10 mins :) and we know it for sure I already changed it. I just verify it
There was a problem hiding this comment.
@Naktibalda currently there is not even an Session adapter interface in branch 4.0.x so let @sergeyklay decide how to proceed :). Maybe it's not consolidated atm.
There was a problem hiding this comment.
Since v4.0.0 session adapters must implement the SessionHandlerInterface interface. There is at least one fundamental difference:
// Phalcon 3.x
public function destroy($removeData = false);
// Phalcon 4.x
public function destroy(string $session_id): bool;Most likely MemorySession34x will not work with Phalcon 4.x.
…eaks (could work trait/composition based though)
…itialization process has not been triggered - adds extra check if the client does actually exist (context free testing | helper | utilities)
| */ | ||
| private function getMemorySessionForVersion() { | ||
| if (strpos(\Phalcon\Version::get(), '3.4') !== false) { | ||
| return PhalconConnector\MemorySession34x::class; |
There was a problem hiding this comment.
Since v4.0.0 session adapters must implement the SessionHandlerInterface interface. There is at least one fundamental difference:
// Phalcon 3.x
public function destroy($removeData = false);
// Phalcon 4.x
public function destroy(string $session_id): bool;Most likely MemorySession34x will not work with Phalcon 4.x.
|
invalid due to zephir compiler to phalcon target version. |
#5328
I did only fix the interfaces and left the other code, besides the module name intact.
I don't mind better solutions but since phalcon is working on 4.x as their current release target and I did not want to impose any structure.
This is a 5 minutes patch, so if there is a method like an internal switch for different versions based on a parameter I am more than willing to adapt this PR.